Run black over the codebase #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulporuri
approved these changes
Sep 27, 2021
| @@ -1021,7 +1000,7 @@ def get_children(self): | |||
| tooltip="Go to next file", | |||
| action="do_parent", | |||
| enabled_when="(selected_node is not None) and " | |||
There was a problem hiding this comment.
Suggested change
| enabled_when="(selected_node is not None) and " | |
| enabled_when=( | |
| "(selected_node is not None) " | |
| "and (object.selected_node.parent is not None)" | |
| ), |
| @@ -1021,7 +1000,7 @@ def get_children(self): | |||
| tooltip="Go to next file", | |||
| action="do_parent", | |||
| enabled_when="(selected_node is not None) and " | |||
| "(object.selected_node.parent is not None)", | |||
| "(object.selected_node.parent is not None)", | |||
There was a problem hiding this comment.
Suggested change
| "(object.selected_node.parent is not None)", |
| @@ -36,7 +36,7 @@ def get_html_tag(tag): | |||
|
|
|||
|
|
|||
| def get_action_enabled(action, model_view): | |||
| """ Helper funciton to return if a tool is enabled. | |||
| """Helper funciton to return if a tool is enabled. | |||
There was a problem hiding this comment.
Suggested change
| """Helper funciton to return if a tool is enabled. | |
| """Helper function to return if a tool is enabled. |
Comment on lines
+53
to
+61
| with mock_iter_entry_points( | ||
| {} | ||
| ), mock_demo_launch(), mocked_io, mock.patch( | ||
| "sys.stdout", mocked_io | ||
| ), mock.patch( | ||
| "sys.stderr", mocked_io | ||
| ), mock.patch( | ||
| "sys.argv", argv | ||
| ): |
There was a problem hiding this comment.
sigh. these look awkward. but we can't use (...) in with statements in Python 3.6 IIUC. Not much we can do if we can to keep the codebase black-happy.
| commands = ["edm environments create {environment} --platform=rh6-x86_64 --force --version={runtime}"] # noqa: E501 | ||
| commands = [ | ||
| "edm environments create {environment} --platform=rh6-x86_64 --force --version={runtime}" | ||
| ] # noqa: E501 |
There was a problem hiding this comment.
Suggested change
| ] # noqa: E501 | |
| ] |
| ]) | ||
| commands = [ | ||
| "edm environments create {environment} --force --version={runtime}" | ||
| ] # noqa: E501 |
There was a problem hiding this comment.
Suggested change
| ] # noqa: E501 | |
| ] |
|
Thanks, I deliberately avoided manual fix-ups in this PR, but the things you noticed are definitely useful for another PR which does things like sort out the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the setup.cfg for the things that now pass. Adds a pyproject.toml so that future runs of black have the same settings.
There is manual clean-up that is needed at this point: there are lines that were protected by
# noqaforE501(line length) which no-longer make sense. Those should be fixed in a separate PR which cleans up theE501status.Checklist