Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Enable and Chaco dependencies #1833

Merged
merged 5 commits into from Feb 23, 2022
Merged

Remove Enable and Chaco dependencies #1833

merged 5 commits into from Feb 23, 2022

Conversation

corranwebster
Copy link
Contributor

@corranwebster corranwebster commented Feb 22, 2022 •
edited

This PR removes the various uses of Enable and Chaco from the TraitsUI codebase. This simplifies the testing dependencies significantly.

Specifically:

  • removes an integration test that was not working and had not been for some considerable time
  • moves another integration test to Enable that ensures the Enable ColorTrait values work in TableEditors with ColorColumns (see Add integration tests from TraitsUI enable#892 for the corresponding Enable PR).
  • changes an example that used a Chaco plot to demonstrate controlling the size of a group to instead use a CodeEditor.
  • removes Chaco and Enable as dependencies in the relevant places in tests.

Fixes #1793 and fixes #1139

Checklist

  • Add a news fragment if this PR is news-worthy for end users. (see docs/releases/README.rst)

@corranwebster
Remove broken integration test.
65cc639 
This test has imports from enable and kiva that don't resolve, and is
otherwise testing things that are already tested elsewhere in TraitsUI,
Kiva and Enable.
@corranwebster
Remover Enable color table test.
402ea36 
This is a test that checks that Enable ColorTraits work with the ColorColumn
in the TableEditor.
@corranwebster
Replace plot editor with a code editor in size demo.
58a8936
@corranwebster
Update dependencies and CI tests.
33af0be
@corranwebster
Add a news fragment.
2d46d57
aaronayres35
aaronayres35 approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

traitsui/examples/demo/Misc/demo_group_size.py
@@ -20,11 +20,9 @@
We separate the left and right groups by a splitter (HSplit), and also
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested the example and it works as expected

@corranwebster corranwebster merged commit 9d05dfc into main Feb 23, 2022
@corranwebster corranwebster deleted the fix/remove-enable-dependencies branch February 23, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronayres35 aaronayres35 aaronayres35 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@corranwebster @aaronayres35