FIX: correct attribute name #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulporuri
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
LGTM. Looks like we need the same fix for wx as well -
traitsui/traitsui/wx/file_editor.py
Line 145 in d5782d0
modified: traitsui/wx/file_editor.py
|
Please could we have a test before this goes in? |
This comment was marked as resolved.
This comment was marked as resolved.
rahulporuri
approved these changes
Mar 10, 2022
corranwebster
added a commit
that referenced
this pull request
Mar 14, 2022
* FIX: correct attribute name * FIX: Use the correct editor factory trait on the wx editor modified: traitsui/wx/file_editor.py * Tests for show_file_dialog and truncate_ext behaviour. * Remove extraneous print_traits() Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Corran Webster <cwebster@enthought.com>
corranwebster
added a commit
that referenced
this pull request
Mar 14, 2022
* FIX: correct attribute name * FIX: Use the correct editor factory trait on the wx editor modified: traitsui/wx/file_editor.py * Tests for show_file_dialog and truncate_ext behaviour. * Remove extraneous print_traits() Co-authored-by: Poruri Sai Rahul <rporuri@enthought.com> Co-authored-by: Corran Webster <cwebster@enthought.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1859
This PR fixes a mis-named attribute accession in the
FileEditor's Qt and Wx implementation. Since the bug makes the editor unusable, I think this will warrant a hotfix release.