Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PySide6 import issues on Linux CI #1893

Merged
merged 14 commits into from
Jun 7, 2022
Merged

Fix PySide6 import issues on Linux CI #1893

merged 14 commits into from
Jun 7, 2022

Conversation

mdickinson
Copy link
Member

@mdickinson mdickinson commented Jun 7, 2022

This PR fixes one cause of CI failures on the current TraitsUI main branch. We're being affected by two separate PySide bugs, namely:

There's still another failure to address, with test_key_click, but that's of quite a different nature and should probably be addressed in a separate PR.

@mdickinson mdickinson changed the title DEBUG: Debugging CI failures Fix PySide6 import issues on Linux CI Jun 7, 2022
@mdickinson mdickinson marked this pull request as ready for review June 7, 2022 12:45
Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for looking into this!

@mdickinson
Copy link
Member Author

Woohoo! Back to passing CI!

@mdickinson mdickinson merged commit 63f77ff into main Jun 7, 2022
@mdickinson mdickinson deleted the debug-issue-1892 branch June 7, 2022 15:26
@mdickinson mdickinson mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants