Don't test wx in the PyPI cron job #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of running the "Test with PyPI" workflow on this branch: https://github.com/enthought/traitsui/actions/runs/2460456639 |
corranwebster
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
A little concerned that this removes the CI infrastructure for running the Wx tests which will need to be recreated if someone decides to get the tests into working condition.
Can we open an issue for getting CI working on Wx, and perhaps include the content of pip-wx for convenience if someone decides to pick it up.
Basically trying to reduce the activation energy needed.
|
Updated to move wxPython testing into its own workflow. The new workflow isn't triggered on a schedule; only manually. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the wx-based tests from the "Test with PyPI" cron job. wx-based testing has already been removed from the regular PR check workflow and the "Test with EDM" cron job.
The wx tests are currently hanging (#1901). The hang is due to a single test, but even if that test is skipped, there are many other test failures. So this run isn't going to be producing a green tick any time soon, and there seems to be little value in having it report a predictable failure every week.