Ensure Qt height and width calls are given int values #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for Python 3.10+ and some versions of PyQt/PySide.
itziakos
reviewed
Jun 28, 2022
itziakos
requested changes
Jun 28, 2022
|
I think I've addressed everything here. Assuming that PRs pass, this is good for re-review. |
itziakos
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for Python 3.10+ with some versions of PyQt/PySide. A change to the Python C API which comes into effect in 3.10 means that certain C API calls which previously accepted floats and silently truncated now raise.
Fixes #1886 and possibly some others.
Note that this looked only for height/width. There may be other places where we are supplying a float when expecting an int.
Checklist