Fix #1929 #1930
Merged
Fix #1929 #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty group leads to Python crash on PyQt5
|
Thanks for the contribution - in principle this looks good. Not sure why the tests failed, so I am re-running them to see if it was a one-off thing or replicable. |
corranwebster
approved these changes
Aug 30, 2022
corranwebster
added
the
need backport to maint/*
|
You are welcome. Your ecosystem is a complete gamechanger for me when creating powerful scientific and enginieering applications, without much effort. It sped up my application development by a factor of >10 (comapred to pure PyQt) while code quality and testability is amazing, great job! |
corranwebster
added a commit
that referenced
this pull request
Oct 3, 2022
* TreeEditor factory callable should support None-type return value (#1848) * "selected" trait the tree editor does not contain all selected items (#1850) * Fix #1914 Empty group leads to Python crash on PyQt5 * Add support for filter_name editor trait in simple-style editor Co-authored-by: Corran Webster <cwebster@enthought.com> Co-authored-by: PyHannes <48917891+pyhannes@users.noreply.github.com>
corranwebster
added a commit
that referenced
this pull request
Oct 3, 2022
* TreeEditor factory callable should support None-type return value (#1848) * "selected" trait the tree editor does not contain all selected items (#1850) * Fix #1914 Empty group leads to Python crash on PyQt5 * Add support for filter_name editor trait in simple-style editor Co-authored-by: Corran Webster <cwebster@enthought.com> Co-authored-by: PyHannes <48917891+pyhannes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1929