Fix progress column rendering on linux and windows #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 16, 2022
|
Thank you @corranwebster. That fix my issue. |
aaronayres35
approved these changes
Sep 16, 2022
There was a problem hiding this comment.
LGTM,
I confirmed the example runs the same and looks correct on both main and this branch on macos
EDIT: Although, FWIW sounds like we had previously observed this working fine on windows both before and after the fix made in 1721 - #964 (comment) / #1721 (review). I guess just linux has a problem with the change from 1721? Regardless the PR shouldn't need to change.
aaronayres35
pushed a commit
that referenced
this pull request
Sep 29, 2022
* Only shift progress column renderers on mac. * Update changelog entry. * Style fix. (cherry picked from commit 0239b8b)
corranwebster
added a commit
that referenced
this pull request
Sep 30, 2022
* Only shift progress column renderers on mac. * Update changelog entry. * Style fix. (cherry picked from commit 0239b8b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1936.
Checklist