Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin PySide6 version to <6.4 #1951

Merged
merged 7 commits into from
Nov 4, 2022
Merged

Pin PySide6 version to <6.4 #1951

merged 7 commits into from
Nov 4, 2022

Conversation

corranwebster
Copy link
Contributor

@corranwebster corranwebster commented Nov 3, 2022

Also turn off EDM/Windows/PySide6/Python3.6 tests - can't get an appropriate PySide6 version and combination is tested with pip dependencies elsewhere.

Checklist

  • Add a news fragment if this PR is news-worthy for end users. (see docs/releases/README.rst)

Copy link
Contributor

@aaronayres35 aaronayres35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corranwebster corranwebster merged commit 890c147 into main Nov 4, 2022
@corranwebster corranwebster deleted the fix/pin-pyside6-version branch November 4, 2022 07:59
@corranwebster corranwebster added the need backport to maint/* PRs that need to be backported to a maintenance branch label Nov 4, 2022
corranwebster added a commit that referenced this pull request Nov 4, 2022
* Pin PySide6 version to <6.4

* Add changelong entry.

* Restrict PySide6 version in etstool.

* Quoting.

* Try quoting the other way.

* One more attempt to get version bound correct.

* Remove EDM PySide6 tests on Windows and Python 3.6
corranwebster added a commit that referenced this pull request Nov 4, 2022
* Pin PySide6 version to <6.4

* Add changelong entry.

* Restrict PySide6 version in etstool.

* Quoting.

* Try quoting the other way.

* One more attempt to get version bound correct.

* Remove EDM PySide6 tests on Windows and Python 3.6
corranwebster added a commit that referenced this pull request Nov 4, 2022
* Pin PySide6 version to <6.4

* Add changelong entry.

* Restrict PySide6 version in etstool.

* Quoting.

* Try quoting the other way.

* One more attempt to get version bound correct.

* Remove EDM PySide6 tests on Windows and Python 3.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need backport to maint/* PRs that need to be backported to a maintenance branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants