Fixes for NewAction in the TreeEditor to remove shared state #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
aaronayres35
approved these changes
Nov 4, 2022
There was a problem hiding this comment.
I tested the example given on the original issue and was able to reproduce the error on my machine on main / confirm that it no longer occurs on this branch.
I also tested to ensure the behavior remains unchanged when not reusing the same tree editor (ie by doing what you described here #1948 (comment)).
| group.id = "" | ||
| # Reset the group for the current usage in case it is shared | ||
| # - the call to `node.get_add()` is potentially dynamic | ||
| group.clear() |
There was a problem hiding this comment.
does the second half of the comment added for wx also apply here?
There was a problem hiding this comment.
Argh - I updated the Qt version but forgot to save and push.
corranwebster
added a commit
that referenced
this pull request
Nov 4, 2022
* Fixes for NewAction in the TreeEditor to remove shared state * Add changelog entry. * Update comment.
corranwebster
added a commit
that referenced
this pull request
Nov 4, 2022
* Fixes for NewAction in the TreeEditor to remove shared state * Add changelog entry. * Update comment.
corranwebster
added a commit
that referenced
this pull request
Nov 4, 2022
* Fixes for NewAction in the TreeEditor to remove shared state * Add changelog entry. * Update comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1948
Unfortunately I'm unsure how to create a regression test for this right now; the underlying code is not factored particularly well, so I'll open a ticket for that: #1954
Checklist