-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit allow_none
in Datetime traits.
#1964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -34,7 +34,7 @@ | |||
class DateEditorDemo(HasTraits): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Off-topic for this PR, but the DateEditorDemo
name is surprising, giving that we're editing a Datetime
trait rather than a Date
trait.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely either copy/paste error or reflecting the fact that there was no Datetime trait until comparatively recently.
I guess we don't need corresponding changes in the |
Hmmmm... it feels like those probably should as well? It's possible that they were missed when grepping for datetime usages. |
Sure, it certainly wouldn't harm. |
Add `allow_none` to `Datetime` bounds in `DatetimeEditor` and to other uses of `Datetime` in tests and examples. This fixes a deprecation warning with recent traits. Fixes #1963.
Add `allow_none` to `Datetime` bounds in `DatetimeEditor` and to other uses of `Datetime` in tests and examples. This fixes a deprecation warning with recent traits. Fixes #1963.
Add
allow_none
toDatetime
bounds inDatetimeEditor
and to other uses ofDatetime
in tests and examples.This fixes a deprecation warning with recent traits.
Fixes #1963.
Checklist