Generate extra TableEditor menus dynamically
#1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the empty_menu, header_menu and related traits. As a result there is a small chance of backwards incompatibility, however: - there are no uses of these traits found in a quick search of the Enthought codebase - any code using these traits is likely buggy, as discovered in #1947 The fixes #1947
jwiggins
approved these changes
Jan 5, 2023
| empty_menu = editor._create_empty_menu() | ||
| if empty_menu is not None: | ||
| event.accept() | ||
| empty_menu.exec_(position) | ||
| else: | ||
| editor.header_row = row |
There was a problem hiding this comment.
Is there other code which is dependent on this mutation of header_row? Otherwise I would think it's better to pass row to _create_header_menu.
There was a problem hiding this comment.
Yes, unfortunately. It's used by most of the handler methods for the default menu Actions (_on_context_insert, _on_context_remove, etc.)
corranwebster
added a commit
that referenced
this pull request
Jan 12, 2023
This removes the `empty_menu`, `header_menu` and related traits. As a result there is a small chance of backwards incompatibility, however: - there are no uses of these traits found in a quick search of the Enthought codebase - any code using these traits is likely buggy, as discovered in #1947 The fixes #1947
corranwebster
added a commit
that referenced
this pull request
Jan 12, 2023
This removes the `empty_menu`, `header_menu` and related traits. As a result there is a small chance of backwards incompatibility, however: - there are no uses of these traits found in a quick search of the Enthought codebase - any code using these traits is likely buggy, as discovered in #1947 The fixes #1947
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
empty_menu,header_menuand related traits. As a result there is a small chance of backwards incompatibility, however:The fixes #1947
Checklist