Protect against deleted nodes in Qt TreeEditor
#1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added issue #1974 for the test segfault on MacOS. |
tmreay
approved these changes
Dec 16, 2022
corranwebster
added a commit
that referenced
this pull request
Jan 12, 2023
* Possible fix for tree editor issues. * Add changelog. * Add tests for new helper function. * Skip helper tests on Mac/PySide6 * Add reference to segfault issue.
corranwebster
added a commit
that referenced
this pull request
Jan 12, 2023
* Possible fix for tree editor issues. * Add changelog. * Add tests for new helper function. * Skip helper tests on Mac/PySide6 * Add reference to segfault issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes checks that the underlying Qt
QTreeViewItemexists before attempting to access any data stored on it. This hopefully resolves some issues observed in PySide6 which I suspect were caused by a change in API from returningAttrbuteErrortoRuntimeErrorwhen accessing that data.Checklist