Printing on generic A4 label paper #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDaut
commented
Dec 18, 2023
CDaut
commented
- Allows printing on generic A4 Label paper
- Allows specifying the test size of the ASNs next to the QR codes to facilitate better readability
|
Hi, thanks for the MR! Can you remove the .idea and gitignore-changes from this MR? |
margau
reviewed
Jan 21, 2024
|
.idea and .gitignore changes should be reverted. |
margau
approved these changes
Jul 13, 2024
margau
requested changes
Jul 13, 2024
| @@ -96,6 +114,7 @@ def __init__(self, label, debug, | |||
| self.across = data.labels_horizontal | |||
| self.down = data.labels_vertical | |||
| self.size = data.label_size | |||
| self.textsize = data.textsize | |||
There was a problem hiding this comment.
Can we define 2mm as default here? This makes it easier/backward compatible?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.