Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch from url.parse() to new URL() #211

Closed
ceejbot opened this issue Jun 8, 2019 · 7 comments
Closed

switch from url.parse() to new URL() #211

ceejbot opened this issue Jun 8, 2019 · 7 comments
Labels
good first issue Good for newcomers registry the public API layer of the backend

Comments

@ceejbot
Copy link
Collaborator

ceejbot commented Jun 8, 2019

The older node url api is deprecated. We should use the newer WHATWG URL api instead.

Once #135 lands we should do a sweep through the codebase and update. There's at least one url.parse usage added by PR #135.
@ceejbot ceejbot added good first issue Good for newcomers registry the public API layer of the backend labels Jun 8, 2019
@moogacs
Copy link
Contributor

moogacs commented Jun 8, 2019

only 1 exists currently , so will wait till #135 finished ?, I mean could be considered from now on to user new URL instead

@ceejbot
Copy link
Collaborator Author

ceejbot commented Jun 9, 2019

I just landed #135 so ... we might be down to only one? That's great! Easier to fix :)

moogacs added a commit to moogacs/entropic that referenced this issue Jun 9, 2019
@moogacs
Switch(entropic-dev#211): url.parse() to new URL()
1174df2
moogacs added a commit to moogacs/entropic that referenced this issue Jun 9, 2019
@moogacs
Switch(entropic-dev#211): url.parse() to new URL()
037446d
moogacs added a commit to moogacs/entropic that referenced this issue Jun 9, 2019
@moogacs
Switch(entropic-dev#211): url.parse() to new URL()
8455213
moogacs added a commit to moogacs/entropic that referenced this issue Jun 9, 2019
@moogacs
Switch(entropic-dev#211): url.parse() to new URL()
9e5cb9a
@moogacs moogacs mentioned this issue Jun 9, 2019
Closed
moogacs added a commit to moogacs/entropic that referenced this issue Jun 9, 2019
@moogacs
Switch(entropic-dev#211): url.parse() to new URL()
713955d
moogacs added a commit to moogacs/entropic that referenced this issue Jun 9, 2019
@moogacs
Switch(entropic-dev#211): url.parse() to new URL()
829b3c7
moogacs added a commit to moogacs/entropic that referenced this issue Jun 9, 2019
@moogacs
Switch(entropic-dev#211): url.parse() to new URL()
2a6ec05 
fix new URL() with base url for node Valid URL
moogacs added a commit to moogacs/entropic that referenced this issue Jun 10, 2019
@moogacs
Switch(entropic-dev#211): url.parse() to new URL()
52846e7 
add pathname
moogacs added a commit to moogacs/entropic that referenced this issue Jun 10, 2019
@moogacs
Switch(entropic-dev#211): url.parse() to new URL()
6e32730 
catch other url
ceejbot pushed a commit that referenced this issue Jun 10, 2019
@moogacs @ceejbot
Switch(#211): url.parse() to new URL() (#223)
b0eeebe 
* Switch(#211): url.parse() to new URL()

* Switch(#211): url.parse() to new URL()

* Switch(#211): url.parse() to new URL()

fix new URL() with base url for node Valid URL

* Switch(#211): url.parse() to new URL()

add pathname

* Switch(#211): url.parse() to new URL()

catch other url
@moogacs
Copy link
Contributor

moogacs commented Jun 10, 2019

@ceejbot , should be closed ?

@zacanger
Copy link
Contributor

zacanger commented Jun 10, 2019 •
edited
Loading

For future reference, if you say Fixes #211 or Closes #211 in the PR description, GitHub will automatically close the associated issue when the PR is merged.

@moogacs
Copy link
Contributor

moogacs commented Jun 10, 2019

what if I edited it now would have an effect ? or it has to be before the PR merged

@zacanger
Copy link
Contributor

It would have to be before the PR is merged

@chrisdickinson
Copy link
Collaborator

We should be good now! Thanks @moogacs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers registry the public API layer of the backend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chrisdickinson @ceejbot @moogacs @zacanger