-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch from url.parse()
to new URL()
#211
Comments
only 1 exists currently , so will wait till #135 finished ?, I mean could be considered from now on to user |
I just landed #135 so ... we might be down to only one? That's great! Easier to fix :) |
fix new URL() with base url for node Valid URL
@ceejbot , should be closed ? |
For future reference, if you say |
what if I edited it now would have an effect ? or it has to be before the PR merged |
It would have to be before the PR is merged |
We should be good now! Thanks @moogacs! |
The older node url api is deprecated. We should use the newer WHATWG URL api instead.
Once #135 lands we should do a sweep through the codebase and update. There's at least one url.parse usage added by PR #135.
The text was updated successfully, but these errors were encountered: