Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add engines field for ds #236

Merged
merged 2 commits into from
Jun 10, 2019

Conversation

1stvamp
Copy link
Contributor

@1stvamp 1stvamp commented Jun 10, 2019

Change Type

  • Feature
  • Chore
  • Bug Fix

Change Level

  • major
  • minor
  • patch

Further Information (screenshots, bug report links, etc.)

As per the readme, the ds CLI only runs in NodeJS v12, so this change adds a engines.node to ds's package.json restricting it to >=12, and uses the NPM_CONFIG_ENGINE_STRICT environment variable in misc/install.sh to temporarily enforce strict engine checking in npm when installing the client.

My reasoning here is that when pulling down the client users may be installing onto older linuxes (such as Ubuntu 16.04) with ancient node versions that need PPAs or other sources to get v12 installed, and that by allowing the install to progress without any warnings could just result in lots more erroneous bugs and general confusion.

Checklist

  • Added tests / did not decrease code coverage
  • Tested in supported environments (common browsers or current Node)

@ceejbot
Copy link
Collaborator

ceejbot commented Jun 10, 2019

Eeeexcellent. Addresses a footgun.

@ceejbot ceejbot merged commit e542afb into entropic-dev:master Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants