Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Type
Change Level
Further Information (screenshots, bug report links, etc.)
As per the readme, the
ds
CLI only runs in NodeJS v12, so this change adds aengines.node
to ds'spackage.json
restricting it to >=12, and uses theNPM_CONFIG_ENGINE_STRICT
environment variable inmisc/install.sh
to temporarily enforce strict engine checking innpm
when installing the client.My reasoning here is that when pulling down the client users may be installing onto older linuxes (such as Ubuntu 16.04) with ancient node versions that need PPAs or other sources to get v12 installed, and that by allowing the install to progress without any warnings could just result in lots more erroneous bugs and general confusion.
Checklist