Vehicles are skipped if optional pricing_plan_id is not not set

[hbruch]

Expected behavior

Vehicles with property pricing_plan_id not explicitly set should not be skipped, as the vehicle type references by vehicle_type_id needs to declare a default_pricing_plan_id, which applies in such a case (see spec GBFSv2.3).

Observed behavior

They are skipped (VehicleFilter assumes getPricingPlanId() returns a non null value).

Version of lamassu used (exact commit hash or JAR name)

28b90d3

Data sets in use (links to GBFS feeds)

e.g. https://stables.donkey.bike/api/public/gbfs/2/donkey_yverdon-les-bains/gbfs.json

[testower]

Nice catch. This probably means we also need to account for that case in the vehicle mapping:

lamassu/src/main/java/org/entur/lamassu/leader/entityupdater/VehiclesUpdater.java

Lines 155 to 162 in 28b90d3

	.map(vehicle ->
	vehicleMapper.mapVehicle(
	vehicle,
	vehicleTypes.get(vehicle.getVehicleTypeId()),
	pricingPlans.get(vehicle.getPricingPlanId()),
	system
	)
	)