Fix: destroy already destroyed workflow environment fails with error (#…

…705)

client/http/errors.go

@@ -13,3 +13,7 @@ func (e *FailedResponseError) Error() string {
 func (e *FailedResponseError) NotFound() bool {
 	return e.res.StatusCode() == 404
 }
+
+func (e *FailedResponseError) BadRequest() bool {
+	return e.res.StatusCode() == 400
+}

env0/resource_environment.go

@@ -7,6 +7,7 @@ import (
 	"regexp"
 
 	"github.com/env0/terraform-provider-env0/client"
+	"github.com/env0/terraform-provider-env0/client/http"
 	"github.com/google/uuid"
 	"github.com/hashicorp/terraform-plugin-log/tflog"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
@@ -756,6 +757,10 @@ func resourceEnvironmentDelete(ctx context.Context, d *schema.ResourceData, meta
 
 	_, err := apiClient.EnvironmentDestroy(d.Id())
 	if err != nil {
+		if frerr, ok := err.(*http.FailedResponseError); ok && frerr.BadRequest() {
+			tflog.Warn(ctx, "Could not delete environment. Already deleted?", map[string]interface{}{"id": d.Id(), "error": frerr.Error()})
+			return nil
+		}
 		return diag.Errorf("could not delete environment: %v", err)
 	}
 	return nil

env0/resource_environment_test.go

@@ -9,6 +9,7 @@ import (
 	"testing"
 
 	"github.com/env0/terraform-provider-env0/client"
+	"github.com/env0/terraform-provider-env0/client/http"
 	"github.com/golang/mock/gomock"
 	"github.com/google/uuid"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
@@ -1619,6 +1620,28 @@ func TestUnitEnvironmentResource(t *testing.T) {
 		})
 	}
 
+	t.Run("Failure in delete", func(t *testing.T) {
+		testCase := resource.TestCase{
+			Steps: []resource.TestStep{
+				{
+					Config: createEnvironmentResourceConfig(environment),
+				},
+			},
+		}
+
+		runUnitTest(t, testCase, func(mock *client.MockApiClientInterface) {
+			mock.EXPECT().Template(environment.LatestDeploymentLog.BlueprintId).Times(1).Return(template, nil)
+			mock.EXPECT().EnvironmentCreate(gomock.Any()).Times(1).Return(environment, nil)
+			mock.EXPECT().EnvironmentDeploy(updatedEnvironment.Id, client.DeployRequest{
+				BlueprintId:       updatedEnvironment.LatestDeploymentLog.BlueprintId,
+				BlueprintRevision: updatedEnvironment.LatestDeploymentLog.BlueprintRevision,
+			}).Times(1).Return(client.EnvironmentDeployResponse{}, errors.New("error"))
+			mock.EXPECT().ConfigurationVariablesByScope(client.ScopeEnvironment, environment.Id).Times(1).Return(client.ConfigurationChanges{}, nil)
+			mock.EXPECT().Environment(gomock.Any()).Times(2).Return(environment, nil)
+			mock.EXPECT().EnvironmentDestroy(environment.Id).Times(1).Return(environment, http.NewMockFailedResponseError(400))
+		})
+	})
+
 	testSuccess()
 	testTTL()
 	testTriggers()