Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: destroy already destroyed workflow environment fails with error #705

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Fix: destroy already destroyed workflow environment fails with error #705

merged 1 commit into from
Sep 4, 2023

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

fixes #704

Solution

  1. On 400 error, prints a warning, but does not fail the destroy.
  2. Updated acceptance tests to cover this use case.

@TomerHeber TomerHeber self-assigned this Sep 2, 2023
@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Sep 4, 2023
@TomerHeber TomerHeber merged commit 3265e71 into main Sep 4, 2023
7 checks passed
@TomerHeber TomerHeber deleted the fix-destroy-fail-#704 branch September 4, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eranelbaz eranelbaz eranelbaz approved these changes

Assignees

@TomerHeber TomerHeber

Labels
api-client fix provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Destroy already destroyed workflow environment fails with error
2 participants
@TomerHeber @eranelbaz