Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support cloud cost credentials #218

Closed
eranelbaz opened this issue Jan 27, 2022 · 3 comments · Fixed by #287, #297 or #307
Closed

support cloud cost credentials #218

eranelbaz opened this issue Jan 27, 2022 · 3 comments · Fixed by #287, #297 or #307
Assignees
Labels
enhancement New feature or request

Comments

@eranelbaz
Copy link
Member

eranelbaz commented Jan 27, 2022

We'd like to add support for our cost credentials.
We'd need the following new resources (and data for each resource)

cost_credentials_project_assignment

Exactly the same as cloud_credentials_project_assignment resource and data. The only difference is that we use different APIs:

aws_cost_credentials

Exactly the same as aws_credentials resource and data (which is a deploy credential, not a cost credential). The schema is exactly the same, and the API calls are the same. The only difference is that the type that should be AWS_ASSUMED_ROLE:

  • Create should be called with correct type and data in value
  • data should filter by type = AWS_ASSUMED_ROLE

azure_cost_credentials

Similar to aws_cost_credentials resource and data. Should use the same APIs, where type is AZURE_CREDENTIALS . For the schema - see docs - value:

  • clientId - required
  • clientSecret - required and sensitive
  • tenantId - required
  • subscriptionId - required
    Other than the schema, differences in API calls are as follows:
  • Create should be called with correct type and data in value
  • data should filter by type = AZURE_CREDENTIALS

google_cost_credentials

Similar to aws_cost_credentials resource and data. Should use the same APIs, where type is GCP_CREDENTIALS. For the schema - see docs - value:

  • tableId - required
  • secret - required and sensitive
    Other than the schema, differences in API calls are as follows:
  • Create should be called with correct type and data in value
  • data should filter by type = GCP_CREDENTIALS
@eranelbaz eranelbaz added the enhancement New feature or request label Jan 27, 2022
@eranelbaz eranelbaz changed the title GCP + Azure cloud credentials GCP + Azure cost cloud credentials Jan 27, 2022
@eranelbaz eranelbaz changed the title GCP + Azure cost cloud credentials support cloud cost credentials Jan 27, 2022
@eranelbaz eranelbaz added this to To do in Ongoing Issues via automation Jan 30, 2022
@RLRabinowitz
Copy link
Contributor

When implementing, feel free to create common API logic, and read/create/delete logic, where necessary

samuel-br added a commit that referenced this issue Mar 8, 2022
@samuel-br samuel-br moved this from To do to In progress in Ongoing Issues Mar 9, 2022
samuel-br added a commit that referenced this issue Mar 9, 2022
samuel-br added a commit that referenced this issue Mar 15, 2022
samuel-br added a commit that referenced this issue Mar 15, 2022
samuel-br added a commit that referenced this issue Mar 15, 2022
samuel-br added a commit that referenced this issue Mar 16, 2022
@samuel-br
Copy link
Contributor

@RLRabinowitz does the update of aws_credentials with access_key and secret_access_key relevant to aws_cost_cred to?

samuel-br added a commit that referenced this issue Mar 20, 2022
@RLRabinowitz
Copy link
Contributor

RLRabinowitz commented Mar 20, 2022

@samuel-br No, cost shouldn’t allow access keys, just assume role.

@samuel-br samuel-br moved this from To do to In progress in Ongoing Issues Mar 27, 2022
Ongoing Issues automation moved this from In progress to Done Mar 28, 2022
samuel-br added a commit that referenced this issue Mar 28, 2022
* add resource and data for azure cost cred

* remove mistake files

* add resource and UT for cost cred assignment
@eranelbaz eranelbaz reopened this Mar 28, 2022
Ongoing Issues automation moved this from Done to To do Mar 28, 2022
samuel-br added a commit that referenced this issue Mar 28, 2022
@eranelbaz eranelbaz moved this from To do to In progress in Ongoing Issues Mar 29, 2022
samuel-br added a commit that referenced this issue Mar 29, 2022
samuel-br added a commit that referenced this issue Mar 29, 2022
samuel-br added a commit that referenced this issue Apr 4, 2022
samuel-br added a commit that referenced this issue Apr 5, 2022
samuel-br added a commit that referenced this issue Apr 5, 2022
samuel-br added a commit that referenced this issue Apr 6, 2022
samuel-br added a commit that referenced this issue Apr 11, 2022
samuel-br added a commit that referenced this issue Apr 11, 2022
samuel-br added a commit that referenced this issue Apr 12, 2022
samuel-br added a commit that referenced this issue Apr 13, 2022
Ongoing Issues automation moved this from In progress to Done Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment