Feat cloud cost credentials #218 #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat_cloud_cost_credentials-#218
…into feat_cloud_cost_credentials-#218
…/env0/terraform-provider-env0 into feat_cloud_cost_credentials-#218
…/env0/terraform-provider-env0 into feat_cloud_cost_credentials-#218
…/env0/terraform-provider-env0 into feat_cloud_cost_credentials-#218
…into feat_cloud_cost_credentials-#218
eranelbaz
requested changes
Mar 21, 2022
There was a problem hiding this comment.
I'm sorry @samuel-br but this PR is wayyy to big for someone to review...
please split this pr
one way to split it is by
- pr for api client
- pr for resources
and please try to make the code a bit more generic, maybe the cost model can contain everything with omit empty so we can use the same common code for all the resource but with different schema
LMK if you need help
|
Closing this one as we you open the splits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
resolves #218
Solution
Add the relevant resources and data