Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop sending external_id for env0_aws_credentials resource #591

Closed
Wassap124 opened this issue Feb 15, 2023 · 2 comments · Fixed by #593
Closed

Stop sending external_id for env0_aws_credentials resource #591

Wassap124 opened this issue Feb 15, 2023 · 2 comments · Fixed by #593
Assignees
@TomerHeber
Labels
blocked enhancement New feature or request
Projects
Ongoing Issues

Comments

@Wassap124
Copy link

Hey hey!

for security reasons, the external_id for env0_aws_credentials is now resolved on the backend, so there no reason to support it anymore.

Please remove it from the resource entirely
@yaronya yaronya added this to To do in Ongoing Issues via automation Feb 15, 2023
@TomerHeber TomerHeber added the enhancement New feature or request label Feb 15, 2023
@TomerHeber TomerHeber moved this from To do to In progress in Ongoing Issues Feb 15, 2023
@TomerHeber TomerHeber mentioned this issue Feb 15, 2023
Merged
TomerHeber added a commit that referenced this issue Feb 15, 2023
@TomerHeber
Merge branch 'main' into feat-remove-external_id-#591
06ce247
@avnerenv0
Copy link
Contributor

Hi @TomerHeber
We still want this and are planning to release it on March 12th.
I think PR #593 is still relevant - we would want to remove the field from the provider at that time.
Sounds OK ?

@TomerHeber
Copy link
Collaborator

TomerHeber commented Feb 28, 2023 •
edited
Loading

@avnerenv0 - sounds good!
Please update me once it's deployed. I will then make the changes in the provider as well.
(At the moment users receive a deprecated message).

Ongoing Issues automation moved this from In progress to Done Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomerHeber TomerHeber

Labels
blocked enhancement New feature or request
Projects
Ongoing Issues
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: stop sending external_id for env0_aws_credentials resource env0/terraform-provider-env0
3 participants
@TomerHeber @Wassap124 @avnerenv0