-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: stop sending external_id for env0_aws_credentials resource #593
Conversation
@@ -23,13 +23,6 @@ func resourceCostCredentials(providerName string) *schema.Resource { | |||
ForceNew: true, | |||
Required: true, | |||
}, | |||
"external_id": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed also from cost credentials...
I was guessing this also needs to be removed. I hope this was correct.
(Worst case, I'll add it back).
@TomerHeber is this ready for review? |
@yaronya it doesn't matter. @TomerHeber sorry but we've had some blowback from our customers regarding this sudden change. Thanks |
@yaronya @avnerenv0 - closing this PR (can re-open in the future). |
deprecation period is over - we want this removed |
@TomerHeber the API is going to ignore external_id from now on and we wanna remove it from the provider - can you resolve the conflicts here please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please resolve the conflicts - other than that - ready to merge 👍
06ce247
to
5b22348
Compare
Issue & Steps to Reproduce / Feature Request
fixes #591
Solution