Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: add proper release drafts #334

Merged
merged 5 commits into from
Apr 19, 2022
Merged

Chore: add proper release drafts #334

merged 5 commits into from
Apr 19, 2022

Conversation

TomerHeber
Copy link
Collaborator

@TomerHeber TomerHeber commented Apr 13, 2022 •
edited
Loading

Solution

Verifies that the PR title has Chore/Fix/Feat.

Part of #324.

@TomerHeber TomerHeber changed the title Chore: add proper release drafts Chore123: add proper release drafts Apr 13, 2022
@TomerHeber TomerHeber changed the title Chore123: add proper release drafts Chore: add proper release drafts Apr 13, 2022
@TomerHeber TomerHeber force-pushed the chore-add-proper-release-drafts-#324 branch from e49394c to 1dd102b Compare April 13, 2022 15:50
@TomerHeber TomerHeber closed this Apr 13, 2022
@TomerHeber TomerHeber reopened this Apr 13, 2022
@TomerHeber TomerHeber requested a review from yaronya April 13, 2022 15:54
yaronya
yaronya reviewed Apr 14, 2022
View reviewed changes
.github/workflows/pr-commit-message-check.yml Outdated
@@ -0,0 +1,19 @@
name: 'Commit Message Check'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So eventually it looks like this on GH UI:
image

I'd suggest to rename it in a way that workflow name would be Validations or similar and the actual job name would be PR Title

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaronya is this what you meant? (see the PR checks).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomerHeber I can't see it in the status checks now...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaronya - you just need to change the title.
In any case, just did it. So you should see it now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomerHeber the name of the status check can't be dynamic since this way you cannot have it as required for the PR to pass.
I'd suggest to have it as Validations / PR Title since we might add more validations in the future

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaronya - modified.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
It seems to fail now 🤔
Can you validate it please?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaronya - where do you see a failure?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK, but I don't see it now so 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably saw it when I was testing (:

@TomerHeber TomerHeber changed the title Chore: add proper release drafts Chore1: add proper release drafts Apr 14, 2022
@TomerHeber TomerHeber changed the title Chore1: add proper release drafts Chore: add proper release drafts Apr 14, 2022
@TomerHeber TomerHeber changed the title Chore: add proper release drafts Chore1: add proper release drafts Apr 17, 2022
@TomerHeber TomerHeber changed the title Chore1: add proper release drafts Chore: add proper release drafts Apr 17, 2022
@TomerHeber TomerHeber requested a review from yaronya April 17, 2022 13:45
yaronya
yaronya previously approved these changes Apr 17, 2022
View reviewed changes
@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Apr 17, 2022
@yaronya yaronya changed the title Chore: add proper release drafts test: add proper release drafts Apr 17, 2022
@yaronya yaronya dismissed their stale review April 17, 2022 21:04

in a 2nd thought...

@yaronya yaronya changed the title test: add proper release drafts Chore: add proper release drafts Apr 17, 2022
@yaronya yaronya added reviewed - awaiting author and removed ready to merge PR approved - can be merged once the PR owner is ready labels Apr 17, 2022
@TomerHeber TomerHeber changed the title Chore: add proper release drafts Chore1: add proper release drafts Apr 18, 2022
@TomerHeber TomerHeber changed the title Chore1: add proper release drafts Chore: add proper release drafts Apr 18, 2022
@TomerHeber TomerHeber requested a review from yaronya April 18, 2022 00:12
@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Apr 19, 2022
@TomerHeber TomerHeber merged commit a0c15b7 into main Apr 19, 2022
@TomerHeber TomerHeber deleted the chore-add-proper-release-drafts-#324 branch April 19, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaronya yaronya yaronya approved these changes

Assignees

@TomerHeber TomerHeber

Labels
chore github-actions ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TomerHeber @yaronya