Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: add proper release drafts #334

Merged
merged 5 commits into from
Apr 19, 2022
Merged

Chore: add proper release drafts #334

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1dd102b
Chore: add proper release drafts
TomerHeber Apr 13, 2022
03d0ab1
change naming
TomerHeber Apr 14, 2022
63e55d2
Merge branch 'main' into chore-add-proper-release-drafts-#324
TomerHeber Apr 16, 2022
118b38f
Merge branch 'main' into chore-add-proper-release-drafts-#324
TomerHeber Apr 17, 2022
e66e240
change naming
TomerHeber Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/pr-commit-message-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: 'Commit Message Check'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So eventually it looks like this on GH UI:
image

I'd suggest to rename it in a way that workflow name would be Validations or similar and the actual job name would be PR Title

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaronya is this what you meant? (see the PR checks).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomerHeber I can't see it in the status checks now...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaronya - you just need to change the title.
In any case, just did it. So you should see it now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomerHeber the name of the status check can't be dynamic since this way you cannot have it as required for the PR to pass.
I'd suggest to have it as Validations / PR Title since we might add more validations in the future

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaronya - modified.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
It seems to fail now 🤔
Can you validate it please?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaronya - where do you see a failure?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK, but I don't see it now so 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably saw it when I was testing (:

on:
pull_request:
types:
- "opened"
- "edited"
- "reopened"
jobs:
check-commit-message:
name: Check Commit Message
runs-on: ubuntu-20.04
timeout-minutes: 1
steps:
- name: Check Title
uses: gsactions/commit-message-checker@v1
with:
pattern: '^.*(Feat|Chore|Fix):.*$'
error: 'You need at least one of "Feat:|Chore:|Fix:" in PR title prefix.'
excludeDescription: true