Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add data source for teams #343

Merged
merged 3 commits into from
Apr 27, 2022
Merged

Feat: add data source for teams #343

merged 3 commits into from
Apr 27, 2022

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

resolves #340

Solution

Added the new data source.
Added unit tests.
Added integration tests.
Added examples.

@TomerHeber TomerHeber self-assigned this Apr 24, 2022
@TomerHeber TomerHeber requested a review from yaronya April 24, 2022 19:00
@yaronya yaronya requested a review from a team April 27, 2022 09:23
@GiliFaroEnv0 GiliFaroEnv0 self-requested a review April 27, 2022 10:10
GiliFaroEnv0
GiliFaroEnv0 reviewed Apr 27, 2022
View reviewed changes
Copy link
Contributor

@GiliFaroEnv0 GiliFaroEnv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GREAT JOB!
Left a minor comment

env0/data_teams.go Show resolved Hide resolved
env0/data_teams.go Show resolved Hide resolved
env0/data_teams.go Outdated Show resolved Hide resolved
tests/integration/021_teams/main.tf Show resolved Hide resolved
TomerHeber and others added 2 commits April 27, 2022 06:52
@TomerHeber @GiliFaroEnv0
Update env0/data_teams.go
b6f4c04 
Co-authored-by: GiliFaroEnv0 <92937594+GiliFaroEnv0@users.noreply.github.com>
@TomerHeber
Merge branch 'main' into feat-add-data-source-for-teams-#340
f40526a
GiliFaroEnv0
GiliFaroEnv0 approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@GiliFaroEnv0 GiliFaroEnv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
as usual great job!

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Apr 27, 2022
@TomerHeber TomerHeber merged commit e4447b5 into main Apr 27, 2022
@TomerHeber TomerHeber deleted the feat-add-data-source-for-teams-#340 branch April 27, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiliFaroEnv0 GiliFaroEnv0 GiliFaroEnv0 approved these changes

@yaronya yaronya Awaiting requested review from yaronya

Assignees

@TomerHeber TomerHeber

Labels
examples feature integration-tests provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add data source for teams
2 participants
@TomerHeber @GiliFaroEnv0