Chore: refactor credentials and cost #407
Conversation
| @@ -27,6 +27,18 @@ func TestCredentialsDataSource(t *testing.T) { | |||
| credentialsType: "AZURE_SERVICE_PRINCIPAL_FOR_DEPLOYMENT", | |||
| cloudType: "azure", | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Adding these cases allows me to remove "data_cost_credentials_test.go".
| "gcp": {string(client.GcpServiceAccountCredentialsType)}, | ||
| "azure": {string(client.AzureServicePrincipalCredentialsType)}, | ||
| "aws": {string(client.AwsAssumedRoleCredentialsType), string(client.AwsAccessKeysCredentialsType)}, | ||
| "google_cost": {string(client.GoogleCostCredentialsType)}, |
There was a problem hiding this comment.
we generally use the gcp term all over the system. Any good reason to change that here?
also, you are keeping the original gcp... so I prefer consistency.
There was a problem hiding this comment.
it's annoying... I agree...
The data source for some reason is called "env0_google_cost..."
I could add some "ifs" if preferred. (Not much better).
There was a problem hiding this comment.
Not a biggy here...
@yaronya FYI maybe for an idea, future refactor.
| return nil | ||
| } | ||
|
|
||
| func resourceCredentialsRead(cloudType string) schema.ReadContextFunc { |
There was a problem hiding this comment.
can we use some kind of string-mapping/enum?
There was a problem hiding this comment.
yeah let me see what I can do.
There was a problem hiding this comment.
@razbensimon , I'll push and fix it in the next PR.
github-actions
bot
added
ready to merge
Solution
Some more refactoring around credentials.
This is part of #394.