Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: refactor credentials and cost #409

Merged
merged 2 commits into from
Jun 6, 2022

Conversation

TomerHeber
Copy link
Collaborator

@TomerHeber TomerHeber commented Jun 2, 2022

Solution

Switched to "Enums" and cleaned up some additional code.
Part of #394

@yaronya
Copy link
Contributor

yaronya commented Jun 6, 2022

@TomerHeber is this still WIP? If not, please update the PR description 🙏

@TomerHeber
Copy link
Collaborator Author

@TomerHeber is this still WIP? If not, please update the PR description 🙏

@yaronya
Yes it's ready for review.
I fixed the description.

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Jun 6, 2022
@TomerHeber TomerHeber merged commit ada0b0f into main Jun 6, 2022
@TomerHeber TomerHeber deleted the chore-refactor-credentials-#394 branch June 6, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants