Feat: refactor resources/data to use the new serialization/deserializ… #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
Jun 8, 2022
| return diag.Errorf(err.Error()) | ||
| } | ||
|
|
||
| var type_ client.ConfigurationVariableType |
There was a problem hiding this comment.
The serializer knows how to handle this use case.
see environment.go func (c *ConfigurationVariableType) ReadResourceData(fieldName string, d *schema.ResourceData) error {...
TomerHeber
commented
Jun 8, 2022
TomerHeber
commented
Jun 12, 2022
TomerHeber
commented
Jun 13, 2022
| assert.Equal(t, params.Description, "description") | ||
| } | ||
|
|
||
| func TestReadByPointerCustomResourceData(t *testing.T) { |
There was a problem hiding this comment.
additional test for the use-case.
TomerHeber
commented
Jun 13, 2022
| assert.Equal(t, params.Description, "description") | ||
| } | ||
|
|
||
| func TestReadByPointerNilCustomResourceData(t *testing.T) { |
There was a problem hiding this comment.
I want to be sure if not set in schema, params.Type remains nil.
sagilaufer1992
approved these changes
Jun 13, 2022
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
Some refactoring in resource configuration variable.
Part of a larger refactoring effort #376