-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: refactor resources/data to use the new serialization/deserializ… #413
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
bd0d78c
Feat: refactor resources/data to use the new serialization/deserializ…
TomerHeber c76342e
Merge branch 'main' into feat-refactor-serialization-#376
TomerHeber 37578de
Merge branch 'main' into feat-refactor-serialization-#376
TomerHeber d6c1200
added a unit test
TomerHeber 1e720ed
fix issues with custom read resource
TomerHeber File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -199,6 +199,53 @@ func TestWriteCustomResourceData(t *testing.T) { | |
assert.Equal(t, configurationVariable.Regex, d.Get("regex")) | ||
} | ||
|
||
func TestReadByValueCustomResourceData(t *testing.T) { | ||
d := schema.TestResourceDataRaw(t, dataConfigurationVariable().Schema, map[string]interface{}{ | ||
"type": "terraform", | ||
"name": "name", | ||
"description": "description", | ||
}) | ||
|
||
params := client.ConfigurationVariableCreateParams{} | ||
|
||
assert.Nil(t, readResourceData(¶ms, d)) | ||
|
||
assert.Equal(t, params.Name, "name") | ||
assert.Equal(t, int(params.Type), 1) | ||
sagilaufer1992 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
assert.Equal(t, params.Description, "description") | ||
} | ||
|
||
func TestReadByPointerCustomResourceData(t *testing.T) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. additional test for the use-case. |
||
d := schema.TestResourceDataRaw(t, dataConfigurationVariable().Schema, map[string]interface{}{ | ||
"type": "terraform", | ||
"name": "name", | ||
"description": "description", | ||
}) | ||
|
||
params := client.ConfigurationVariable{} | ||
|
||
assert.Nil(t, readResourceData(¶ms, d)) | ||
|
||
assert.Equal(t, params.Name, "name") | ||
assert.Equal(t, int(*params.Type), 1) | ||
assert.Equal(t, params.Description, "description") | ||
} | ||
|
||
func TestReadByPointerNilCustomResourceData(t *testing.T) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I want to be sure if not set in schema, params.Type remains nil. |
||
d := schema.TestResourceDataRaw(t, dataConfigurationVariable().Schema, map[string]interface{}{ | ||
"name": "name", | ||
"description": "description", | ||
}) | ||
|
||
params := client.ConfigurationVariable{} | ||
|
||
assert.Nil(t, readResourceData(¶ms, d)) | ||
|
||
assert.Equal(t, params.Name, "name") | ||
assert.Nil(t, params.Type) | ||
assert.Equal(t, params.Description, "description") | ||
} | ||
|
||
func TestWriteResourceDataSliceVariablesAgents(t *testing.T) { | ||
d := schema.TestResourceDataRaw(t, dataAgents().Schema, map[string]interface{}{}) | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The serializer knows how to handle this use case.
see environment.go
func (c *ConfigurationVariableType) ReadResourceData(fieldName string, d *schema.ResourceData) error {...