Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: better environment force_destroy docs #421

Merged
merged 5 commits into from
Jun 18, 2022

Conversation

liranfarage89
Copy link
Contributor

@liranfarage89 liranfarage89 commented Jun 16, 2022

Issue & Steps to Reproduce / Feature Request

Imri from ActiveFence was trying to destroy an environment by deleting it from the code, he didn't know he has to set force_destroy before, he suggested documenting that.

Solution

Add it to the docs

@@ -64,7 +64,7 @@ resource "env0_environment" "example_with_hcl_configuration" {
- **auto_deploy_on_path_changes_only** (Boolean) redeploy only on path changes only
- **configuration** (Block List) terraform and environment variables for the environment (see [below for nested schema](#nestedblock--configuration))
- **deploy_on_push** (Boolean) should run terraform deploy on push events
- **force_destroy** (Boolean) destroy safegurad
- **force_destroy** (Boolean) Destroy safeguard. Must be enabled before delete/destroy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liranfarage89 the markdown files are auto-generated so we should not update them manually

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot removed the docs label Jun 16, 2022
@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Jun 18, 2022
@yaronya yaronya merged commit a89958d into main Jun 18, 2022
@yaronya yaronya deleted the chore-better-force-destroy-docs branch June 18, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants