Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: deprecate 'external_id' #598

Merged
merged 4 commits into from
Feb 26, 2023
Merged

Chore: deprecate 'external_id' #598

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70415b7
Chore: deprecate 'external_id'
TomerHeber Feb 20, 2023
d73665b
updated schema based on PR feedback
TomerHeber Feb 22, 2023
3cc75ef
Merge branch 'main' into chore-deprecate-external_id-#593
TomerHeber Feb 22, 2023
5dff9ec
Merge branch 'main' into chore-deprecate-external_id-#593
yaronya Feb 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion env0/resource_aws_credentials.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ func resourceAwsCredentials() *schema.Resource {
Sensitive: true,
ForceNew: true,
ConflictsWith: []string{"access_key_id"},
RequiredWith: []string{"arn"},
Deprecated: "field will be removed in the near future",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this field should also become optional, don't we need to remove
RequiredWith: []string{"arn"} ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure I can do that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the "requiredWith".
for costs I added optional and removed required.

},
"access_key_id": {
Type: schema.TypeString,
Expand Down
3 changes: 2 additions & 1 deletion env0/resource_cost_credentials.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ func resourceCostCredentials(providerName string) *schema.Resource {
Description: "the aws role external id",
Sensitive: true,
ForceNew: true,
Required: true,
Optional: true,
Deprecated: "field will be removed in the near future",
},
}

Expand Down