Chore: deprecate 'external_id' #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaronya
previously approved these changes
Feb 22, 2023
github-actions
bot
added
ready to merge
avnerenv0
reviewed
Feb 22, 2023
| @@ -38,6 +38,7 @@ func resourceAwsCredentials() *schema.Resource { | |||
| ForceNew: true, | |||
| ConflictsWith: []string{"access_key_id"}, | |||
| RequiredWith: []string{"arn"}, | |||
| Deprecated: "field will be removed in the near future", | |||
There was a problem hiding this comment.
this field should also become optional, don't we need to remove
RequiredWith: []string{"arn"} ?
There was a problem hiding this comment.
sure I can do that.
There was a problem hiding this comment.
removed the "requiredWith".
for costs I added optional and removed required.
yaronya
added
reviewed - awaiting author
and removed
ready to merge
yaronya
approved these changes
Feb 26, 2023
github-actions
bot
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
Related to #593.
For now just a deprecation message.