Feat: run harness tests in parallel #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerHeber
commented
Jun 30, 2023
| @@ -24,16 +25,27 @@ func main() { | |||
| log.Println(len(testNames), " tests to run") | |||
| buildFakeTerraformRegistry() | |||
| destroyMode := os.Getenv("DESTROY_MODE") | |||
|
|
|||
| var wg sync.WaitGroup | |||
There was a problem hiding this comment.
Nothing fancy. Running each test inside a go-routine.
Waits for all tests to finish.
If a test fails halts and exits (all tests stop).
github-actions
bot
added
ready to merge
GiliFaroEnv0
added a commit
that referenced
this pull request
Jul 3, 2023
This reverts commit b33c6b1.
GiliFaroEnv0
added a commit
that referenced
this pull request
Jul 3, 2023
TomerHeber
added a commit
that referenced
this pull request
Jul 8, 2023
TomerHeber
added a commit
that referenced
this pull request
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
resolves #657
Solution
Tests are now running in parallel. Time is reduced from ~10+ minutes to ~3 minutes