Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Feat: run harness tests in parallel" #670

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

GiliFaroEnv0
Copy link
Contributor

@GiliFaroEnv0 GiliFaroEnv0 commented Jul 3, 2023

Reverts #669

we have integration tests that search for all the existing templates (022) / teams (021) and it found entities from other test while they being destroyed (deleted) which causes a race condition.

we need to find a different solution for #657

@github-actions github-actions bot added the ready to merge PR approved - can be merged once the PR owner is ready label Jul 3, 2023
@GiliFaroEnv0 GiliFaroEnv0 merged commit e2f3f6e into main Jul 3, 2023
6 checks passed
@GiliFaroEnv0 GiliFaroEnv0 deleted the revert-669-feat-parallel-harness-#657 branch July 3, 2023 08:14
TomerHeber added a commit that referenced this pull request Jul 8, 2023
TomerHeber added a commit that referenced this pull request Jul 11, 2023
* Revert "Revert "Feat: run harness tests in parallel (#669)" (#670)"

This reverts commit e2f3f6e.

* updated integration tests to avoid race conditions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants