Fix: do not send terraformVersion unused field #701
Conversation
| @@ -78,7 +78,7 @@ type TemplateCreatePayload struct { | |||
| GitlabProjectId int `json:"gitlabProjectId,omitempty"` | |||
| Revision string `json:"revision"` | |||
| OrganizationId string `json:"organizationId"` | |||
| TerraformVersion string `json:"terraformVersion"` | |||
| TerraformVersion string `json:"terraformVersion,omitempty"` | |||
There was a problem hiding this comment.
Hi @TomerHeber , I'm Sagy from RND, nice to github-meet you 😃
on purpose you don't have the tfschema:",omitempty" syntax here also?
There was a problem hiding this comment.
Hi @sagydr - nice to meet you (:
tfschema omitempty is only needed when reading from a struct and writing to the terraform schema.
For this struct we read from the terraform schema and write to the struct.
When transforming to a json, the json omitempty will be used and the field will not be sent.
(if string == "" then the field isn't passed in the json).
Happy to explain more if this is still unclear. (Didn't want the explanation to be too long).
| @@ -111,7 +111,7 @@ type VariablesFromRepositoryPayload struct { | |||
| Repository string `json:"repository"` | |||
| } | |||
|
|
|||
| func (payload TemplateCreatePayload) Validate() error { | |||
| func (payload *TemplateCreatePayload) Invalidate() error { | |||
There was a problem hiding this comment.
I understand the asterix * is used to de-reference the variable to its value. Did it also work before this change?
There was a problem hiding this comment.
Hi @sagydr - ahh that's a golang question (:
without "" is readonly function - you can't modify "this".
with "" you can modify "this".
| templateCreatePayload.TerraformVersion = "" | ||
| updateTemplateCreateTemplate.TerraformVersion = "" |
There was a problem hiding this comment.
Just out of curiosity as I'm not too familiar with Go, templateCreatePayload & updateTemplateCreateTemplate have many common fields, is it not common to extract them to something like BaseTemplate struct? Like in Python?
There was a problem hiding this comment.
Can be done, but not very common.
There was a problem hiding this comment.
To add on this: Golang does not have inheritance and is not object oriented.
https://go.dev/doc/faq#:~:text=Types-,Is%20Go%20an%20object%2Doriented%20language%3F,in%20some%20ways%20more%20general.
github-actions
bot
added
ready to merge
Issue & Steps to Reproduce / Feature Request
fixes #659
Solution