Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: configuration variable defined in env0_environment resource gett… #768

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

TomerHeber
Copy link
Collaborator

…ing 'updated' in plan

Issue & Steps to Reproduce / Feature Request

fixes #756

Solution

Workflow parent environment is using "WORKFLOW" scope instead of "ENVIRONMENT" scope.
Fixed issue and updated tests.

Copy link
Contributor

@avnerenv0 avnerenv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't make me happy but I approve 🙏

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Dec 13, 2023
@TomerHeber
Copy link
Collaborator Author

@avnerenv0 - doesn't make me happy as well. Any suggestions?

@TomerHeber TomerHeber merged commit 5d8d820 into main Dec 13, 2023
5 checks passed
@TomerHeber TomerHeber deleted the fix-workflow-conf-drift-#756 branch December 13, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration Variable defined in env0_environment resource getting "updated" in plan
2 participants