Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: support tagPrefix on modules #776

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Feat: support tagPrefix on modules #776

merged 4 commits into from
Jan 10, 2024

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

resolves #775

Solution

  1. Updated the module schema.
  2. Updated the module API structs.
  3. Updated the module acceptance tests.
  4. Updated the module integration tests.

@TomerHeber TomerHeber self-assigned this Jan 5, 2024
sagilaufer1992
sagilaufer1992 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@sagilaufer1992 sagilaufer1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Jan 10, 2024
@TomerHeber TomerHeber merged commit 414b6c9 into main Jan 10, 2024
5 checks passed
@TomerHeber TomerHeber deleted the feat-module-tag_prefix-#775 branch January 10, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagilaufer1992 sagilaufer1992 sagilaufer1992 approved these changes

@yaronya yaronya Awaiting requested review from yaronya

Assignees

@TomerHeber TomerHeber

Labels
api-client feature integration-tests provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: support tagPrefix on modules
2 participants
@TomerHeber @sagilaufer1992