Feat: add environment import id scope to configuration variable #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonnoga
changed the title
alonnoga
changed the title
|
@alonnoga - you should add a test. |
Hey @TomerHeber 👋🏻 it wasn't ready for review then, its ready now 🙏🏻 |
|
We decided to reuse environment variable scope instead, I'll create another pr to allow not deleting a variable when removed from config |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Steps to Reproduce / Feature Request
Part of #856
We added a new scope for environment import
It should not delete the variable when removed ( like how we don't delete environment imports when the resource is removed from the configuration )