Add support for annotating multiple gem lock files #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Orien Madgwick <_@orien.io>
johnsyweb
reviewed
May 12, 2021
johnsyweb
reviewed
May 12, 2021
johnsyweb
reviewed
May 12, 2021
johnsyweb
reviewed
May 12, 2021
| def self.run_unwapper_in_pwd(base_branch:) | ||
| return unless lockfile_present? | ||
| def self.run_unwapper_in_pwd(base_branch:, lock_files:) | ||
| return unless lockfiles_present?(lock_files) | ||
|
|
||
| puts "Doing the unwrappr thing in #{Dir.pwd}" |
There was a problem hiding this comment.
It would be good to provide some feedback to show that each lockfile has been updated / evaluated.
There was a problem hiding this comment.
Good idea. Added in 24b143c.
Co-authored-by: Pete Johns <johnsyweb@users.noreply.github.com>
johnsyweb
approved these changes
May 12, 2021
Co-authored-by: Pete Johns <johnsyweb@users.noreply.github.com>
petervandoros
force-pushed
the
multiple-gem-lock-files
branch
from
ab957bb
to
1a5ed9c
Compare
In some cases, only one of the specified lock files may be present, which is enough for it to function.
petervandoros
force-pushed
the
multiple-gem-lock-files
branch
from
0768780
to
605f57a
Compare
petervandoros
force-pushed
the
multiple-gem-lock-files
branch
from
a0ce2ad
to
24b143c
Compare
|
@johnsyweb @orien thanks for reviewing and providing feedback! I think I've addressed all the feedback, so would be great if you could cast your eyes over the changes one more time? |
|
@johnsyweb Could you please publish the latest version of this gem when you get a chance? |
|
TIL bootboot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to be able annotate multiple Gemfile lock files in a single PR. It's especially useful when working with a dual booting system such as bootboot.
This PR adds support for annotating multiple Gemfile lock files.