-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for annotating multiple gem lock files #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Nice one!
Co-authored-by: Orien Madgwick <_@orien.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
def self.run_unwapper_in_pwd(base_branch:) | ||
return unless lockfile_present? | ||
def self.run_unwapper_in_pwd(base_branch:, lock_files:) | ||
return unless lockfiles_present?(lock_files) | ||
|
||
puts "Doing the unwrappr thing in #{Dir.pwd}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to provide some feedback to show that each lockfile has been updated / evaluated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. Added in 24b143c.
Co-authored-by: Pete Johns <johnsyweb@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this enhancement. I've made a few UX-based comments but otherwise, I'd be happy to release this.
Co-authored-by: Pete Johns <johnsyweb@users.noreply.github.com>
ab957bb
to
1a5ed9c
Compare
In some cases, only one of the specified lock files may be present, which is enough for it to function.
0768780
to
605f57a
Compare
a0ce2ad
to
24b143c
Compare
@johnsyweb @orien thanks for reviewing and providing feedback! I think I've addressed all the feedback, so would be great if you could cast your eyes over the changes one more time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
@johnsyweb Could you please publish the latest version of this gem when you get a chance? |
TIL bootboot. |
It's useful to be able annotate multiple Gemfile lock files in a single PR. It's especially useful when working with a dual booting system such as bootboot.
This PR adds support for annotating multiple Gemfile lock files.