Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: enable explicit setting of API base path and prefix #246

Merged
merged 1 commit into from
Jul 24, 2022

Conversation

morremeyer
Copy link
Member

This renders the complicated and error-prone auto-detection obsolete.
It also enables the use of the swagger documentation to directly
interact with the API.

BREAKING CHANGE: URLs are no longer generated by autodetection.
You need to set the environment variable API_HOST_PROTOCOL and,
if the API is at a sub-path, API_BASE_PATH.

@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #246 (667a562) into main (2f34928) will decrease coverage by 0.61%.
The diff coverage is 77.08%.

@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
- Coverage   97.18%   96.57%   -0.62%     
==========================================
  Files          15       16       +1     
  Lines        1316     1313       -3     
==========================================
- Hits         1279     1268      -11     
- Misses         26       34       +8     
  Partials       11       11              
Impacted Files Coverage Δ
pkg/httputil/request.go 100.00% <ø> (+6.12%) ⬆️
internal/router/middleware.go 8.33% <8.33%> (ø)
internal/router/router.go 90.75% <100.00%> (+1.03%) ⬆️
pkg/controllers/account.go 100.00% <100.00%> (ø)
pkg/controllers/allocation.go 100.00% <100.00%> (ø)
pkg/controllers/budget.go 97.82% <100.00%> (ø)
pkg/controllers/category.go 97.93% <100.00%> (ø)
pkg/controllers/envelope.go 97.61% <100.00%> (ø)
pkg/controllers/transaction.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f34928...667a562. Read the comment docs.

This renders the complicated and error-prone auto-detection obsolete.
It also enables the use of the swagger documentation to directly
interact with the API.

BREAKING CHANGE: URLs are no longer generated by autodetection.
You need to set the environment variable API_HOST_PROTOCOL and,
if the API is at a sub-path, API_BASE_PATH.
@morremeyer morremeyer merged commit ed6d9cd into main Jul 24, 2022
@morremeyer morremeyer deleted the feat/swagger-editing branch July 24, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant