Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login screen always says password incorrect irrespective of login error. #483

Closed
KaairaGupta opened this issue Feb 28, 2020 · 0 comments
Closed

Comments

@KaairaGupta
Copy link

Login error can be:

  1. Password incorrect
  2. Username not-found
  3. Network error

Current app (built from develop) rightly handles the third error but always says "This password is incorrect." even if username was not found.

I understand this can be privacy breach to tell if username was found or not, so I would like to have to get your input @dewall about how we should approach this issue. Also, we may need to change the server response if we use the information of existence of a username.

Simplest solution could be to simply show message: "Username or password was incorrect.".

I would like to work on this issue myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants