Refactor track list components to use org.envirocar.map module
#1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmercerind
force-pushed
the
feature/refactor-tracklist-to-map-module
branch
from
259d069
to
4bd4642
Compare
alexmercerind
commented
Jun 11, 2024
alexmercerind
commented
Jun 11, 2024
org.envirocar.app/src/org/envirocar/app/views/recordingscreen/TrackMapFragment.java
Show resolved
Hide resolved
alexmercerind
commented
Jun 11, 2024
alexmercerind
commented
Jun 11, 2024
org.envirocar.app/src/org/envirocar/app/views/trackdetails/TrackMapFactory.kt
Outdated
Show resolved
Hide resolved
|
The migrated code appears to be working properly with
Unfortunately, other views which are still dependent on Mapbox v9 directly are crashing due to this. The workaround resolves the compile time issue, but crashes on runtime. |
|
Superseded by #1005 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request refactors the track list views to utilize the newly introduced map module:
org.envirocar.mapModule #1003The referenced views now use
org.envirocar.mapmodule instead of Mapbox v9 directly. A substantial part of implementation (primarily the files including any map related code) has been migrated to Kotlin.