Scrollbar for Car Selection screen #719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
increased version for release
|
@arvindnegi1 @bpross-52n sir can you please review this PR? |
|
@SebaDro sir please review it. |
|
@SebaDro @arvindnegi1 @bpross-52n can you please review it before it gets superseded? |
|
This PR only provides minor style improvements, which are not considered. Therefore, I will close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #718
Description:
Added themed Scrollbar for the Car Selection screen to improve the user interface of the android application. The scrollbar is not static/fixed. It fades away if not used for a few seconds. The scrollbar is a component of AndroidX and no 3rd party library is used which increases the compatibility of the component in the app. The scrollbar will only appear if items exceed the screen size as of to improve user's ease of access. The length of scrollbar is not fixed and varies according to the entities present
Sample demo of current Car Selection screen:
Sample demo of Car Selection screen with Scrollbar: