Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Add Fueling screen #729

Merged
merged 5 commits into from
Aug 19, 2021
Merged

Conversation

Akash-Ramjyothi
Copy link
Contributor

Fixes: #728

Description:

Added materialized icons for all input fields relevant to the Title to improve consistency and user interface of the Add Fueling screen.

Screenshot of current Add Fueling screen:

WhatsApp Image 2021-04-09 at 1 40 50 AM

Screenshot of fixed Add Fueling screen:

WhatsApp Image 2021-04-09 at 2 31 07 AM

@Akash-Ramjyothi
Copy link
Contributor Author

@arvindnegi1 @bpross-52n sir can you please review this PR?

@Akash-Ramjyothi Akash-Ramjyothi changed the base branch from develop to gsoc2021 June 16, 2021 18:13
@Akash-Ramjyothi
Copy link
Contributor Author

@SebaDro sir please review it.

@Akash-Ramjyothi Akash-Ramjyothi changed the base branch from gsoc2021 to develop July 22, 2021 07:08
@Akash-Ramjyothi
Copy link
Contributor Author

@SebaDro @arvindnegi1 @bpross-52n can you please review it before it gets superseded?

Copy link
Member

@asaikarthikeya asaikarthikeya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @Akash-Ramjyothi for this PR. I have spoke to @SebaDro about this PR. Sir also liked this UI improvement, We will definitely merge this PR in coming weeks ;)

@Akash-Ramjyothi
Copy link
Contributor Author

@asaikarthikeya Thank you so much for your approval and for the update. I hope it gets Merged and not Superseded :).

@SebaDro SebaDro self-requested a review August 19, 2021 10:59
@SebaDro SebaDro merged commit 85957ea into enviroCar:develop Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants