Replaced Terms and conditions and Privacy statment dialogs with link to web page #799
Conversation
Record_2021-08-26-20-17-09.mp4 |
| .subscribe(tou -> LOG.info("Closed Dialog")); | ||
| } | ||
| private void showTermsOfUseBrowser() { | ||
| String TOUwebpage = "https://envirocar.org/TermsOfUse.html?lng=en"; //TOU-->TermsOfUse |
There was a problem hiding this comment.
Currently app supports 2 languages. By setting URL this way, App always opens english terms and conditions. I would suggest you to find another alternate approach by with we can direct to the URL based on the language present in the App. https://envirocar.org/TermsOfUse.html?lng=de
There was a problem hiding this comment.
@asaikarthikeya umm if I do
if Locale.getDefault().getLanguage() returns "de" then I can do
the above link you mentioned
else or else if ("en") then english link
but to test i will have to run the version in german, can you guide me on where can I get that?
org.envirocar.app/src/org/envirocar/app/views/login/SignupActivity.java
Outdated
Show resolved
Hide resolved
|
@asaikarthikeya i have made requested changes, you can checkout |
|
sorry, by mistake mention. |
|
@asaikarthikeya Can you review this PR so I can make a new PR for #795 ? |
|
Hello @DhirajChauhan40, Develop has been updated just now. You can rebase this PR on top of the new changes in develop. And regarding #795, There is some code added in this updated develop which helps in closing keyboard on background click ( see pr #775 ) . May be you can reuse some part of this code. Thanks ;-) |
| TOUintent.setData(Uri.parse(TOUwebpage)); | ||
| startActivity(TOUintent); | ||
| } | ||
| } else if (Locale.getDefault().getLanguage() == "de"){ |
There was a problem hiding this comment.
Use else instead of else if.
| startActivity(condintent); | ||
| } | ||
| } | ||
| else if(Locale.getDefault().getLanguage() == "de") { |
|
@asaikarthikeya I have made the requested changes you can review now. Thanks. |
fixes #589