Password authentication made stronger. Error messages more informative #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage is now more informative.
asaikarthikeya
suggested changes
Jan 25, 2022
| @@ -81,7 +81,7 @@ | |||
| private static final Logger LOG = Logger.getLogger(SignupActivity.class); | |||
|
|
|||
| private static final String EMAIL_REGEX = "^[_A-Za-z0-9-\\+]+(\\.[_A-Za-z0-9-]+)*@[A-Za-z0-9-]+(\\.[A-Za-z0-9-]+)*(\\.[A-Za-z]{2,})$"; | |||
| private static final String PASSWORD_REGEX = "^(?=.*?[A-Z])(?=.*?[a-z])(?=.*?[0-9]).{6,}$"; | |||
| private static final String PASSWORD_REGEX = "^(?=.*[0-9])(?=.*[a-z])(?=.*[A-Z])(?=.*[@#$%^&+=])(?=\\S+$).{6,}$"; | |||
There was a problem hiding this comment.
The current implementation is sufficent as of now. Also to implement this enhancement first the changes should be made on server so that the app gets supported with the new changes.
| <string name="error_username_contain_special">Special symbol not allowed except underscore</string> | ||
| <string name="error_field_weak_password">Password must contain at least one uppercase letter, one lowercase letter and one digit</string> | ||
| <string name="error_field_weak_password">Password must contain at least one uppercase letter, one lowercase letter , one digit and one special character</string> |
| <string name="error_incorrect_password">This password is incorrect.</string> | ||
| <string name="error_invalid_credentials">Username or password is incorrect</string> | ||
| <string name="error_field_required">This field is required.</string> | ||
| <string name="error_not_connected_to_network">Not connected to network</string> | ||
| <string name="register_progress_signing_in">Registering…</string> | ||
| <string name="error_passwords_not_matching">The passwords do not match.</string> | ||
| <string name="error_invalid_username">This username is too short.</string> | ||
| <string name="error_invalid_username">This username is too short.Username must be of atleast 6 characters.</string> |
There was a problem hiding this comment.
Yes. This is a good enhancement. Kindly remove the extra space between letters and add space after fullstop.
| @@ -22,16 +22,16 @@ | |||
| <string name="action_sign_in_register">Register</string> | |||
| <string name="action_sign_in_short">Sign in</string> | |||
| <string name="error_invalid_email">This email address is invalid.</string> | |||
| <string name="error_invalid_password">This password is too short.</string> | |||
| <string name="error_invalid_password">This password is too short.Password must be of atleast 6 characters.</string> | |||
There was a problem hiding this comment.
Add space after full-stop.
asaikarthikeya
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Password authentication made stronger by adding special character option. Error password and username message is now more informative (shows the exact length required). A possible fix for #881 . Kindly review @asaikarthikeya