Added FAB in Help Section to Scroll #925
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@asaikarthikeya please review my PR. |
|
Hello @Akash-Ramjyothi, Kindly add screenshots so that we could see the visual changes that you have made, Also rebase your PR's on top of the previous changes. Thanks |
FAB in Help Section:WhatsApp.Video.2022-07-13.at.9.46.09.AM.mp4 |
SebaDro
requested changes
Sep 22, 2022
There was a problem hiding this comment.
This is a nice feature. However, I would a expect the FAB to be sticky, so that users may scroll back to the top from anywhere. In addition, adjust the color of the FAB to be consistent with all other UI elements. Check the color of the FAB in the car list view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #928 .
Description:
Currently, the Help Activity has a lot of contents at once for Users to go through. Implemented a Floating Action Button in the Help Activity, by which when the user is scrolling down, a Button will appear through which he will directly be scrolled/ navigated to the top of the section. This will improve the UX of the app.