Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced Butter Knife view binding with Jetpack View Binding #935

Open
wants to merge 19 commits into
base: gsoc2022
Choose a base branch
from
Open

Replaced Butter Knife view binding with Jetpack View Binding #935

wants to merge 19 commits into from

Conversation

Akash-Ramjyothi
Copy link
Contributor

@Akash-Ramjyothi Akash-Ramjyothi commented Jun 30, 2022 •
edited

Fixes: #934 .

Description:

Replaced the deprecated Butterknife ViewBinding with Jetpack ViewBinding. By upgrading to Jetpack Viewbinding, the following Impact are seen in the app.

  • Jetpack ViewBinding is compile time safe.
  • It builds the app faster.
  • Less boilerplate referencing.
  • No more BindView annotations.
  • Provides Type safety.
  • Provides Null safety.

@Akash-Ramjyothi Akash-Ramjyothi changed the base branch from master to gsoc2022 June 30, 2022 20:20
@Akash-Ramjyothi
Fixed minor error
ccb49e6
@Akash-Ramjyothi
Added ViewBInding for HelpActivity
48435d4
@Akash-Ramjyothi
Added ViewBInding for RermsOfUseActivity
315d0b9
@Akash-Ramjyothi
Added ViewBinding for TimePickerPreferenceDialog
964f888
@Akash-Ramjyothi
Added ViewBinding for BaseMainActivity
78ceb2a
@Akash-Ramjyothi
Upgraded androidRoom dependency
b452316
@Akash-Ramjyothi
Added ViewBinding for Basic views
790bcd1
@Akash-Ramjyothi
Added ViewBinding for carselection Views
e808e4d
@Akash-Ramjyothi
Added Jetpack ViewBinding for dashboard Views
6da345c
@Akash-Ramjyothi
Added Jetpack ViewBinding for logbook Views
baa3e26
@Akash-Ramjyothi
Added Jetpack ViewBinding for login Views
2fb042c
@Akash-Ramjyothi
Added Jetpack ViewBinding for obdselection Views
f5aa5a0
@Akash-Ramjyothi
Added Jetpack ViewBinding for others Views
650559d
@Akash-Ramjyothi
Added Jetpack ViewBinding for preferences Views
7c52d77
@Akash-Ramjyothi
Added Jetpack ViewBinding for recordingscreen Views
b5a4c8e
@Akash-Ramjyothi
Added Jetpack ViewBinding for custom Views
3af08ce
@Akash-Ramjyothi
Added Jetpack ViewBinding for trackdetails Views
c4597c2
@Akash-Ramjyothi
Added Jetpack ViewBinding for tracklist Views
a5daf12
@Akash-Ramjyothi Akash-Ramjyothi mentioned this pull request Jun 30, 2022
Open
@Akash-Ramjyothi Akash-Ramjyothi marked this pull request as ready for review July 12, 2022 04:49
@Akash-Ramjyothi
Copy link
Contributor Author

@asaikarthikeya please see my PR.

@Akash-Ramjyothi
Copy link
Contributor Author

Fixes Issue #885 .

@Akash-Ramjyothi Akash-Ramjyothi mentioned this pull request Dec 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement GSoC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Butter Knife view binding with Jetpack View Binding
2 participants
@Akash-Ramjyothi @SebaDro