-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showing ProgressDialog at the time of bluetooth pairing #977
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SanjaySargam . Thanks for your contribution.
I really like the solution for showing a progress bar when pairing performs. Just a small suggestion: we already have a DialogUtils helper class that provides some methods to create a MaterialAlertDialogBuilder
with progress bar. It would be great, if you could use this helper class to create the dialog, since it also applies the enviroCar theme on the dialog, which preserves consistence in the UX
What do you think about it?
Ok I will use existing Dialog in helper class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, change the color of the Bluetooth icon to be white and select the develop branch as target branch for your pull request. After that I will merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather expect the Bluetooth icon to be white, as every ProgressDialog has a white icon.
@SebaDro Ok |
Well, I think it's possible to edit the present pull request and change the target branch. If not, just create a new one and close the old. |
Fixes #969
ScreenRecording
WhatsApp.Video.2023-03-06.at.11.35.15.PM.mp4